Skip to content

feat: update notification services to support mobile.#5120

Merged
Prithpal-Sooriya merged 10 commits intomainfrom
MMASSETS-493/decouple-push-logic-to-be-platform-agnostic
Feb 21, 2025
Merged

feat: update notification services to support mobile.#5120
Prithpal-Sooriya merged 10 commits intomainfrom
MMASSETS-493/decouple-push-logic-to-be-platform-agnostic

Conversation

@Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jan 9, 2025 •
edited
Loading

Explanation

This is a large PR that enables support for push notifications on mobile.

Makes Push Notification Controller Platform Agnostic

The NotificationServicesPushController was highly tied to web and was not compatible for react-native.
We now have isolated the web logic inweb/push-utils.ts, and allow platforms to overwrite and inject a push service into the controller. E.g. Mobile can inject push services using react-native modules.

Add support to toggle push notifications on/off in isolation

This allows us to decouple in-app notifications from push notifications. It is done by adding a isPushEnabled boolean inside the NotificationServicesPushController.

We have also added public methods enablePushNotifications and disablePushNotifications inside the NotificationServicesController to allow us tie it to UI Actions.

References

Changelog

@metamask/notification-services-controller

  • ADDED: isPushEnabled state to NotificationServicesPushControllerState to enable and disable this controller/
  • ADDED: isUpdatingFCMToken state to NotificationServicesPushControllerState to track when the controller is updating for firebase registration token.
  • ADDED: PushService interface and default web implementation for push notifciations
  • CHANGED (BREAKING): NotificationServicesPushController config now allows injecting of a PushService interface during controller creation.
  • ADDED: /push-services/web subpath export to import web specific push services.
  • ADDED: /shared folder including some shared utils used in controllers for this package.
  • ADDED: public method enablePushNotifications and disablePushNotifications in NotificationServicesController to enable and disable push notifications in isolation.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 9, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "20.0.2-preview-4e54ae1",
  "@metamask-previews/address-book-controller": "6.0.2-preview-4e54ae1",
  "@metamask-previews/announcement-controller": "7.0.2-preview-4e54ae1",
  "@metamask-previews/approval-controller": "7.1.1-preview-4e54ae1",
  "@metamask-previews/assets-controllers": "45.1.2-preview-4e54ae1",
  "@metamask-previews/base-controller": "7.1.0-preview-4e54ae1",
  "@metamask-previews/build-utils": "3.0.2-preview-4e54ae1",
  "@metamask-previews/chain-controller": "0.2.2-preview-4e54ae1",
  "@metamask-previews/composable-controller": "10.0.0-preview-4e54ae1",
  "@metamask-previews/controller-utils": "11.4.4-preview-4e54ae1",
  "@metamask-previews/ens-controller": "15.0.1-preview-4e54ae1",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-4e54ae1",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-4e54ae1",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-4e54ae1",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-4e54ae1",
  "@metamask-previews/keyring-controller": "19.0.2-preview-4e54ae1",
  "@metamask-previews/logging-controller": "6.0.3-preview-4e54ae1",
  "@metamask-previews/message-manager": "11.0.3-preview-4e54ae1",
  "@metamask-previews/multichain": "2.0.0-preview-4e54ae1",
  "@metamask-previews/name-controller": "8.0.2-preview-4e54ae1",
  "@metamask-previews/network-controller": "22.1.1-preview-4e54ae1",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-4e54ae1",
  "@metamask-previews/permission-controller": "11.0.4-preview-4e54ae1",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-4e54ae1",
  "@metamask-previews/phishing-controller": "12.3.1-preview-4e54ae1",
  "@metamask-previews/polling-controller": "12.0.2-preview-4e54ae1",
  "@metamask-previews/preferences-controller": "15.0.1-preview-4e54ae1",
  "@metamask-previews/profile-sync-controller": "3.2.0-preview-4e54ae1",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-4e54ae1",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-4e54ae1",
  "@metamask-previews/remote-feature-flag-controller": "1.2.0-preview-4e54ae1",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-4e54ae1",
  "@metamask-previews/signature-controller": "23.2.0-preview-4e54ae1",
  "@metamask-previews/transaction-controller": "42.1.0-preview-4e54ae1",
  "@metamask-previews/user-operation-controller": "21.0.0-preview-4e54ae1"
}

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 15, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.0-preview-55b37eea",
  "@metamask-previews/address-book-controller": "6.0.2-preview-55b37eea",
  "@metamask-previews/announcement-controller": "7.0.2-preview-55b37eea",
  "@metamask-previews/approval-controller": "7.1.2-preview-55b37eea",
  "@metamask-previews/assets-controllers": "46.0.0-preview-55b37eea",
  "@metamask-previews/base-controller": "7.1.1-preview-55b37eea",
  "@metamask-previews/build-utils": "3.0.2-preview-55b37eea",
  "@metamask-previews/composable-controller": "10.0.0-preview-55b37eea",
  "@metamask-previews/controller-utils": "11.4.5-preview-55b37eea",
  "@metamask-previews/ens-controller": "15.0.1-preview-55b37eea",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-55b37eea",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-55b37eea",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-55b37eea",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-55b37eea",
  "@metamask-previews/keyring-controller": "19.0.3-preview-55b37eea",
  "@metamask-previews/logging-controller": "6.0.3-preview-55b37eea",
  "@metamask-previews/message-manager": "11.0.3-preview-55b37eea",
  "@metamask-previews/multichain": "2.0.0-preview-55b37eea",
  "@metamask-previews/name-controller": "8.0.2-preview-55b37eea",
  "@metamask-previews/network-controller": "22.1.1-preview-55b37eea",
  "@metamask-previews/notification-services-controller": "0.16.0-preview-55b37eea",
  "@metamask-previews/permission-controller": "11.0.5-preview-55b37eea",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-55b37eea",
  "@metamask-previews/phishing-controller": "12.3.1-preview-55b37eea",
  "@metamask-previews/polling-controller": "12.0.2-preview-55b37eea",
  "@metamask-previews/preferences-controller": "15.0.1-preview-55b37eea",
  "@metamask-previews/profile-sync-controller": "4.1.0-preview-55b37eea",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-55b37eea",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-55b37eea",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-55b37eea",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-55b37eea",
  "@metamask-previews/signature-controller": "23.2.0-preview-55b37eea",
  "@metamask-previews/transaction-controller": "43.0.0-preview-55b37eea",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-55b37eea"
}

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 15, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.0-preview-a7b445fc",
  "@metamask-previews/address-book-controller": "6.0.2-preview-a7b445fc",
  "@metamask-previews/announcement-controller": "7.0.2-preview-a7b445fc",
  "@metamask-previews/approval-controller": "7.1.2-preview-a7b445fc",
  "@metamask-previews/assets-controllers": "46.0.0-preview-a7b445fc",
  "@metamask-previews/base-controller": "7.1.1-preview-a7b445fc",
  "@metamask-previews/build-utils": "3.0.2-preview-a7b445fc",
  "@metamask-previews/composable-controller": "10.0.0-preview-a7b445fc",
  "@metamask-previews/controller-utils": "11.4.5-preview-a7b445fc",
  "@metamask-previews/ens-controller": "15.0.1-preview-a7b445fc",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-a7b445fc",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-a7b445fc",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-a7b445fc",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-a7b445fc",
  "@metamask-previews/keyring-controller": "19.0.3-preview-a7b445fc",
  "@metamask-previews/logging-controller": "6.0.3-preview-a7b445fc",
  "@metamask-previews/message-manager": "11.0.3-preview-a7b445fc",
  "@metamask-previews/multichain": "2.0.0-preview-a7b445fc",
  "@metamask-previews/name-controller": "8.0.2-preview-a7b445fc",
  "@metamask-previews/network-controller": "22.1.1-preview-a7b445fc",
  "@metamask-previews/notification-services-controller": "0.16.0-preview-a7b445fc",
  "@metamask-previews/permission-controller": "11.0.5-preview-a7b445fc",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-a7b445fc",
  "@metamask-previews/phishing-controller": "12.3.1-preview-a7b445fc",
  "@metamask-previews/polling-controller": "12.0.2-preview-a7b445fc",
  "@metamask-previews/preferences-controller": "15.0.1-preview-a7b445fc",
  "@metamask-previews/profile-sync-controller": "4.1.0-preview-a7b445fc",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-a7b445fc",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-a7b445fc",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-a7b445fc",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-a7b445fc",
  "@metamask-previews/signature-controller": "23.2.0-preview-a7b445fc",
  "@metamask-previews/transaction-controller": "43.0.0-preview-a7b445fc",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-a7b445fc"
}

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 23, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-5f45f70f",
  "@metamask-previews/address-book-controller": "6.0.2-preview-5f45f70f",
  "@metamask-previews/announcement-controller": "7.0.2-preview-5f45f70f",
  "@metamask-previews/approval-controller": "7.1.2-preview-5f45f70f",
  "@metamask-previews/assets-controllers": "46.0.1-preview-5f45f70f",
  "@metamask-previews/base-controller": "7.1.1-preview-5f45f70f",
  "@metamask-previews/build-utils": "3.0.2-preview-5f45f70f",
  "@metamask-previews/composable-controller": "10.0.0-preview-5f45f70f",
  "@metamask-previews/controller-utils": "11.4.5-preview-5f45f70f",
  "@metamask-previews/ens-controller": "15.0.1-preview-5f45f70f",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-5f45f70f",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-5f45f70f",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-5f45f70f",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-5f45f70f",
  "@metamask-previews/keyring-controller": "19.0.4-preview-5f45f70f",
  "@metamask-previews/logging-controller": "6.0.3-preview-5f45f70f",
  "@metamask-previews/message-manager": "12.0.0-preview-5f45f70f",
  "@metamask-previews/multichain": "2.1.0-preview-5f45f70f",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-5f45f70f",
  "@metamask-previews/name-controller": "8.0.2-preview-5f45f70f",
  "@metamask-previews/network-controller": "22.1.1-preview-5f45f70f",
  "@metamask-previews/notification-services-controller": "0.16.0-preview-5f45f70f",
  "@metamask-previews/permission-controller": "11.0.5-preview-5f45f70f",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-5f45f70f",
  "@metamask-previews/phishing-controller": "12.3.1-preview-5f45f70f",
  "@metamask-previews/polling-controller": "12.0.2-preview-5f45f70f",
  "@metamask-previews/preferences-controller": "15.0.1-preview-5f45f70f",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-5f45f70f",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-5f45f70f",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-5f45f70f",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-5f45f70f",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-5f45f70f",
  "@metamask-previews/signature-controller": "23.2.0-preview-5f45f70f",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-5f45f70f",
  "@metamask-previews/transaction-controller": "43.0.0-preview-5f45f70f",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-5f45f70f"
}

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the MMASSETS-493/decouple-push-logic-to-be-platform-agnostic branch 2 times, most recently from 29ca3da to 21576f2 Compare January 23, 2025 19:22
@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 29, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-15ff43f9",
  "@metamask-previews/address-book-controller": "6.0.2-preview-15ff43f9",
  "@metamask-previews/announcement-controller": "7.0.2-preview-15ff43f9",
  "@metamask-previews/approval-controller": "7.1.2-preview-15ff43f9",
  "@metamask-previews/assets-controllers": "46.0.1-preview-15ff43f9",
  "@metamask-previews/base-controller": "7.1.1-preview-15ff43f9",
  "@metamask-previews/build-utils": "3.0.2-preview-15ff43f9",
  "@metamask-previews/composable-controller": "10.0.0-preview-15ff43f9",
  "@metamask-previews/controller-utils": "11.4.5-preview-15ff43f9",
  "@metamask-previews/ens-controller": "15.0.1-preview-15ff43f9",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-15ff43f9",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-15ff43f9",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-15ff43f9",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-15ff43f9",
  "@metamask-previews/keyring-controller": "19.0.4-preview-15ff43f9",
  "@metamask-previews/logging-controller": "6.0.3-preview-15ff43f9",
  "@metamask-previews/message-manager": "12.0.0-preview-15ff43f9",
  "@metamask-previews/multichain": "2.1.0-preview-15ff43f9",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-15ff43f9",
  "@metamask-previews/name-controller": "8.0.2-preview-15ff43f9",
  "@metamask-previews/network-controller": "22.1.1-preview-15ff43f9",
  "@metamask-previews/notification-services-controller": "0.17.0-preview-15ff43f9",
  "@metamask-previews/permission-controller": "11.0.5-preview-15ff43f9",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-15ff43f9",
  "@metamask-previews/phishing-controller": "12.3.1-preview-15ff43f9",
  "@metamask-previews/polling-controller": "12.0.2-preview-15ff43f9",
  "@metamask-previews/preferences-controller": "15.0.1-preview-15ff43f9",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-15ff43f9",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-15ff43f9",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-15ff43f9",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-15ff43f9",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-15ff43f9",
  "@metamask-previews/signature-controller": "23.2.0-preview-15ff43f9",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-15ff43f9",
  "@metamask-previews/transaction-controller": "43.0.0-preview-15ff43f9",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-15ff43f9"
}

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 30, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "22.0.0-preview-c96fc296",
  "@metamask-previews/address-book-controller": "6.0.2-preview-c96fc296",
  "@metamask-previews/announcement-controller": "7.0.2-preview-c96fc296",
  "@metamask-previews/approval-controller": "7.1.2-preview-c96fc296",
  "@metamask-previews/assets-controllers": "47.0.0-preview-c96fc296",
  "@metamask-previews/base-controller": "7.1.1-preview-c96fc296",
  "@metamask-previews/build-utils": "3.0.2-preview-c96fc296",
  "@metamask-previews/composable-controller": "10.0.0-preview-c96fc296",
  "@metamask-previews/controller-utils": "11.4.5-preview-c96fc296",
  "@metamask-previews/ens-controller": "15.0.1-preview-c96fc296",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-c96fc296",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-c96fc296",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-c96fc296",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-c96fc296",
  "@metamask-previews/keyring-controller": "19.0.5-preview-c96fc296",
  "@metamask-previews/logging-controller": "6.0.3-preview-c96fc296",
  "@metamask-previews/message-manager": "12.0.0-preview-c96fc296",
  "@metamask-previews/multichain": "2.1.0-preview-c96fc296",
  "@metamask-previews/multichain-transactions-controller": "0.1.0-preview-c96fc296",
  "@metamask-previews/name-controller": "8.0.2-preview-c96fc296",
  "@metamask-previews/network-controller": "22.1.1-preview-c96fc296",
  "@metamask-previews/notification-services-controller": "0.18.0-preview-c96fc296",
  "@metamask-previews/permission-controller": "11.0.5-preview-c96fc296",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-c96fc296",
  "@metamask-previews/phishing-controller": "12.3.1-preview-c96fc296",
  "@metamask-previews/polling-controller": "12.0.2-preview-c96fc296",
  "@metamask-previews/preferences-controller": "15.0.1-preview-c96fc296",
  "@metamask-previews/profile-sync-controller": "5.0.0-preview-c96fc296",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-c96fc296",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-c96fc296",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-c96fc296",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-c96fc296",
  "@metamask-previews/signature-controller": "23.2.0-preview-c96fc296",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-c96fc296",
  "@metamask-previews/transaction-controller": "44.0.0-preview-c96fc296",
  "@metamask-previews/user-operation-controller": "23.0.0-preview-c96fc296"
}

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 30, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "22.0.0-preview-442894ce",
  "@metamask-previews/address-book-controller": "6.0.2-preview-442894ce",
  "@metamask-previews/announcement-controller": "7.0.2-preview-442894ce",
  "@metamask-previews/approval-controller": "7.1.2-preview-442894ce",
  "@metamask-previews/assets-controllers": "47.0.0-preview-442894ce",
  "@metamask-previews/base-controller": "7.1.1-preview-442894ce",
  "@metamask-previews/build-utils": "3.0.2-preview-442894ce",
  "@metamask-previews/composable-controller": "10.0.0-preview-442894ce",
  "@metamask-previews/controller-utils": "11.4.5-preview-442894ce",
  "@metamask-previews/ens-controller": "15.0.1-preview-442894ce",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-442894ce",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-442894ce",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-442894ce",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-442894ce",
  "@metamask-previews/keyring-controller": "19.0.5-preview-442894ce",
  "@metamask-previews/logging-controller": "6.0.3-preview-442894ce",
  "@metamask-previews/message-manager": "12.0.0-preview-442894ce",
  "@metamask-previews/multichain": "2.1.0-preview-442894ce",
  "@metamask-previews/multichain-transactions-controller": "0.1.0-preview-442894ce",
  "@metamask-previews/name-controller": "8.0.2-preview-442894ce",
  "@metamask-previews/network-controller": "22.1.1-preview-442894ce",
  "@metamask-previews/notification-services-controller": "0.18.0-preview-442894ce",
  "@metamask-previews/permission-controller": "11.0.5-preview-442894ce",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-442894ce",
  "@metamask-previews/phishing-controller": "12.3.1-preview-442894ce",
  "@metamask-previews/polling-controller": "12.0.2-preview-442894ce",
  "@metamask-previews/preferences-controller": "15.0.1-preview-442894ce",
  "@metamask-previews/profile-sync-controller": "5.0.0-preview-442894ce",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-442894ce",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-442894ce",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-442894ce",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-442894ce",
  "@metamask-previews/signature-controller": "23.2.0-preview-442894ce",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-442894ce",
  "@metamask-previews/transaction-controller": "44.0.0-preview-442894ce",
  "@metamask-previews/user-operation-controller": "23.0.0-preview-442894ce"
}

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the MMASSETS-493/decouple-push-logic-to-be-platform-agnostic branch from c4913ce to 9f24308 Compare February 19, 2025 18:31
@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Feb 19, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "24.0.0-preview-9f243081",
  "@metamask-previews/address-book-controller": "6.0.3-preview-9f243081",
  "@metamask-previews/announcement-controller": "7.0.3-preview-9f243081",
  "@metamask-previews/approval-controller": "7.1.3-preview-9f243081",
  "@metamask-previews/assets-controllers": "50.0.0-preview-9f243081",
  "@metamask-previews/base-controller": "8.0.0-preview-9f243081",
  "@metamask-previews/bridge-controller": "0.0.0-preview-9f243081",
  "@metamask-previews/build-utils": "3.0.3-preview-9f243081",
  "@metamask-previews/composable-controller": "11.0.0-preview-9f243081",
  "@metamask-previews/controller-utils": "11.5.0-preview-9f243081",
  "@metamask-previews/earn-controller": "0.4.0-preview-9f243081",
  "@metamask-previews/ens-controller": "15.0.2-preview-9f243081",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-9f243081",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-9f243081",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-9f243081",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-9f243081",
  "@metamask-previews/keyring-controller": "19.2.0-preview-9f243081",
  "@metamask-previews/logging-controller": "6.0.4-preview-9f243081",
  "@metamask-previews/message-manager": "12.0.1-preview-9f243081",
  "@metamask-previews/multichain": "2.1.1-preview-9f243081",
  "@metamask-previews/multichain-network-controller": "0.1.1-preview-9f243081",
  "@metamask-previews/multichain-transactions-controller": "0.4.0-preview-9f243081",
  "@metamask-previews/name-controller": "8.0.3-preview-9f243081",
  "@metamask-previews/network-controller": "22.2.1-preview-9f243081",
  "@metamask-previews/notification-services-controller": "0.21.0-preview-9f243081",
  "@metamask-previews/permission-controller": "11.0.6-preview-9f243081",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-9f243081",
  "@metamask-previews/phishing-controller": "12.3.2-preview-9f243081",
  "@metamask-previews/polling-controller": "12.0.3-preview-9f243081",
  "@metamask-previews/preferences-controller": "15.0.2-preview-9f243081",
  "@metamask-previews/profile-sync-controller": "8.1.0-preview-9f243081",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-9f243081",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-9f243081",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-9f243081",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-9f243081",
  "@metamask-previews/signature-controller": "23.2.1-preview-9f243081",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-9f243081",
  "@metamask-previews/transaction-controller": "46.0.0-preview-9f243081",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-9f243081"
}

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "24.0.0-preview-5575cd05",
  "@metamask-previews/address-book-controller": "6.0.3-preview-5575cd05",
  "@metamask-previews/announcement-controller": "7.0.3-preview-5575cd05",
  "@metamask-previews/approval-controller": "7.1.3-preview-5575cd05",
  "@metamask-previews/assets-controllers": "50.0.0-preview-5575cd05",
  "@metamask-previews/base-controller": "8.0.0-preview-5575cd05",
  "@metamask-previews/bridge-controller": "0.0.0-preview-5575cd05",
  "@metamask-previews/build-utils": "3.0.3-preview-5575cd05",
  "@metamask-previews/composable-controller": "11.0.0-preview-5575cd05",
  "@metamask-previews/controller-utils": "11.5.0-preview-5575cd05",
  "@metamask-previews/earn-controller": "0.4.0-preview-5575cd05",
  "@metamask-previews/ens-controller": "15.0.2-preview-5575cd05",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-5575cd05",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-5575cd05",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-5575cd05",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-5575cd05",
  "@metamask-previews/keyring-controller": "19.2.0-preview-5575cd05",
  "@metamask-previews/logging-controller": "6.0.4-preview-5575cd05",
  "@metamask-previews/message-manager": "12.0.1-preview-5575cd05",
  "@metamask-previews/multichain": "2.1.1-preview-5575cd05",
  "@metamask-previews/multichain-network-controller": "0.1.1-preview-5575cd05",
  "@metamask-previews/multichain-transactions-controller": "0.4.0-preview-5575cd05",
  "@metamask-previews/name-controller": "8.0.3-preview-5575cd05",
  "@metamask-previews/network-controller": "22.2.1-preview-5575cd05",
  "@metamask-previews/notification-services-controller": "0.21.0-preview-5575cd05",
  "@metamask-previews/permission-controller": "11.0.6-preview-5575cd05",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-5575cd05",
  "@metamask-previews/phishing-controller": "12.3.2-preview-5575cd05",
  "@metamask-previews/polling-controller": "12.0.3-preview-5575cd05",
  "@metamask-previews/preferences-controller": "15.0.2-preview-5575cd05",
  "@metamask-previews/profile-sync-controller": "8.1.0-preview-5575cd05",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-5575cd05",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-5575cd05",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-5575cd05",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-5575cd05",
  "@metamask-previews/signature-controller": "23.2.1-preview-5575cd05",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-5575cd05",
  "@metamask-previews/transaction-controller": "46.0.0-preview-5575cd05",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-5575cd05"
}

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Feb 19, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "24.0.0-preview-cc687932",
  "@metamask-previews/address-book-controller": "6.0.3-preview-cc687932",
  "@metamask-previews/announcement-controller": "7.0.3-preview-cc687932",
  "@metamask-previews/approval-controller": "7.1.3-preview-cc687932",
  "@metamask-previews/assets-controllers": "50.0.0-preview-cc687932",
  "@metamask-previews/base-controller": "8.0.0-preview-cc687932",
  "@metamask-previews/bridge-controller": "0.0.0-preview-cc687932",
  "@metamask-previews/build-utils": "3.0.3-preview-cc687932",
  "@metamask-previews/composable-controller": "11.0.0-preview-cc687932",
  "@metamask-previews/controller-utils": "11.5.0-preview-cc687932",
  "@metamask-previews/earn-controller": "0.4.0-preview-cc687932",
  "@metamask-previews/ens-controller": "15.0.2-preview-cc687932",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-cc687932",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-cc687932",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-cc687932",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-cc687932",
  "@metamask-previews/keyring-controller": "19.2.0-preview-cc687932",
  "@metamask-previews/logging-controller": "6.0.4-preview-cc687932",
  "@metamask-previews/message-manager": "12.0.1-preview-cc687932",
  "@metamask-previews/multichain": "2.1.1-preview-cc687932",
  "@metamask-previews/multichain-network-controller": "0.1.1-preview-cc687932",
  "@metamask-previews/multichain-transactions-controller": "0.4.0-preview-cc687932",
  "@metamask-previews/name-controller": "8.0.3-preview-cc687932",
  "@metamask-previews/network-controller": "22.2.1-preview-cc687932",
  "@metamask-previews/notification-services-controller": "0.21.0-preview-cc687932",
  "@metamask-previews/permission-controller": "11.0.6-preview-cc687932",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-cc687932",
  "@metamask-previews/phishing-controller": "12.3.2-preview-cc687932",
  "@metamask-previews/polling-controller": "12.0.3-preview-cc687932",
  "@metamask-previews/preferences-controller": "15.0.2-preview-cc687932",
  "@metamask-previews/profile-sync-controller": "8.1.0-preview-cc687932",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-cc687932",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-cc687932",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-cc687932",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-cc687932",
  "@metamask-previews/signature-controller": "23.2.1-preview-cc687932",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-cc687932",
  "@metamask-previews/transaction-controller": "46.0.0-preview-cc687932",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-cc687932"
}

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review February 21, 2025 11:37
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners February 21, 2025 11:37
mathieuartu
mathieuartu approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for addressing the changes! LGTM!!

@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) February 21, 2025 13:18
@Prithpal-Sooriya Prithpal-Sooriya changed the title feat: decouple push logic to be platform agnostic feat: update notification services to support mobile. Feb 21, 2025
@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) February 21, 2025 13:34
@Prithpal-Sooriya Prithpal-Sooriya merged commit 92924a7 into main Feb 21, 2025
136 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the MMASSETS-493/decouple-push-logic-to-be-platform-agnostic branch February 21, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathieuartu mathieuartu mathieuartu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Prithpal-Sooriya @mathieuartu